Allow setting the newline character when serializing #747
Conversation
|
Only one comment on your PR, once that's fixed, I'll merge it in and we can get this closed. |
|
Great, where can I find this comment ...? |
| @@ -122,6 +128,19 @@ public EmitterSettings WithMaxSimpleKeyLength(int maxSimpleKeyLength) | |||
| ); | |||
| } | |||
|
|
|||
| public EmitterSettings WithNewLine(string newLine) | |||
There was a problem hiding this comment.
You need to include NewLine in the other With methods, otherwise, it'll get lost if another With method is called after the WithNewLine
There was a problem hiding this comment.
Ahh, great - I'll figure it out - Thx
There was a problem hiding this comment.
Should be pretty simple, it looks like that same thing was missed for the indented sequences.
There was a problem hiding this comment.
Actually, as I went through the file, I saw that indentSequences was suffering from the same problem, as in if invoking any other "With" method after having applied indentSequences, it would discard the previously applied value. I'm not sure how to isolate this in a separate pull request, since it's a CTOR invocation, and the newLine value is after the indentSequences value in the CTOR arguments. Anyways, I've pushed now, including the fix for indentSequences ...
There was a problem hiding this comment.
Thanks for fixing the indent at the same time. Looks like the Canonical method was missed though.
There was a problem hiding this comment.
There is one method, but it only allows for setting it to true. will you merge this in anyways? I guess it's an unrelated issue ...?
If you're merging, when can we have a new release? I need the NuGet package in our own stuff ...
There was a problem hiding this comment.
I cut releases right after merging in. You should see a new package up on nuget in a few minutes.
There was a problem hiding this comment.
Thx Edward, you're a champ ^_^
|
I just re-commented it. It said it was pending, whatever that means. |
EdwardCooke
changed the title
To avoid loosing information when another "With" method is invoked afterwards
|
Looks like the github action that cuts the release is failing, I'll have to look at it tomorrow or this weekend, most likely the weekend. I suspect we need to upgrade the version of dot net that the build project uses since it's targeting 3.1 and the github agents apparently only have 6.0 and 7.0 on them. https://github.com/aaubry/YamlDotNet/actions/runs/3590103979/jobs/6043184163#step:4:24 Once I get it resolved, I'll post back here. |
|
Thx |
|
This is on it's way out to NuGet. Should be there in a few minutes. |
|
Thx mate |
|
Actually, I can't find it? Not sure why. The last version is 12.0.2 that was published 2 months ago ... |
|
@aaubry - Hi Antoine, not sure why, but there's still no updated version at NuGet ...? |
|
This feature has been released in version 12.1.0. |
|
Thx, finally I can see it at NuGet :) |
Welcome!
Thanks for your interest in contributing to this project. Any contribution will
be gladly accepted, provided that they are generally useful and follow the
conventions of the project.
Please create one pull request for each feature. This results in smaller pull requests that are easier to review and validate.
Avoid reformatting existing code unless you are making other changes to it.
usings is acceptable, if you made other changes to that file.Always add one or more unit tests that prove that the feature / fix you are submitting is working correctly.
Please describe the motivation behind the pull request. Explain what was the problem / requirement. Unless the implementation is self-explanatory, also describe the solution.
Follow the project's coding conventions